Skip to content

refactor: Remove most usages of IAppContainer and IServerContainer#60780

Open
CarlSchwan wants to merge 2 commits into
masterfrom
carl/modernize-containers
Open

refactor: Remove most usages of IAppContainer and IServerContainer#60780
CarlSchwan wants to merge 2 commits into
masterfrom
carl/modernize-containers

Conversation

@CarlSchwan

@CarlSchwan CarlSchwan commented May 27, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan CarlSchwan force-pushed the carl/modernize-containers branch 4 times, most recently from aed4795 to 7d2081f Compare May 28, 2026 10:10
@CarlSchwan CarlSchwan marked this pull request as ready for review May 28, 2026 10:14
@CarlSchwan CarlSchwan requested review from ArtificialOwl, come-nc, leftybournes and salmart-dev and removed request for a team May 28, 2026 10:14
provokateurin
provokateurin requested changes May 28, 2026
View reviewed changes

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay you got me :D

Comment thread lib/private/AppFramework/Bootstrap/RegistrationContext.php Outdated
Comment thread lib/private/AppFramework/Bootstrap/RegistrationContext.php Outdated
Comment thread lib/private/AppFramework/Bootstrap/RegistrationContext.php Outdated
Comment thread lib/private/AppFramework/Bootstrap/RegistrationContext.php Outdated
Comment thread lib/private/User/Session.php Outdated
Comment thread tests/lib/Log/LogFactoryTest.php Outdated
@CarlSchwan CarlSchwan force-pushed the carl/modernize-containers branch 5 times, most recently from d685b87 to 2cb0c38 Compare May 29, 2026 08:40
come-nc
come-nc reviewed Jun 1, 2026
View reviewed changes
Comment thread lib/public/AppFramework/App.php Outdated
@CarlSchwan CarlSchwan force-pushed the carl/modernize-containers branch from 2cb0c38 to 1839e8a Compare June 1, 2026 09:59
@CarlSchwan CarlSchwan requested a review from provokateurin June 1, 2026 10:00
@come-nc

come-nc commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Related

There was 1 error:

1) lib\AppFramework\Bootstrap\RegistrationContextTest::testRegisterServiceAlias
PHPUnit\Framework\MockObject\MethodCannotBeConfiguredException: Trying to configure method "registerAlias" which cannot be configured because it does not exist, has not been specified, is final, or is static

/home/runner/actions-runner/_work/server/server/tests/lib/AppFramework/Bootstrap/RegistrationContextTest.php:100

@CarlSchwan CarlSchwan mentioned this pull request Jun 2, 2026
Closed
8 tasks
@CarlSchwan
refactor: Remove most usages of IAppContainer and IServerContainer
cc0e585 
And port more stuff to standard ContainerInterface interface

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
fix(ISession): Fix typo in api doc
f46295b 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the carl/modernize-containers branch from 1839e8a to f46295b Compare June 2, 2026 08:08
@susnux susnux added this to the Nextcloud 35 milestone Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes

@provokateurin provokateurin provokateurin approved these changes

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan @come-nc @miaulalala @provokateurin @susnux